Skip to content

Any Failure in Annotate Terminates the Annotate job #469

@estebanreyl

Description

@estebanreyl

Context:

In annotator.go, the Annotate function currently fails the entire annotation job if any single manifest annotation fails. This does not seem ideal

Problem:
The current implementation returns an error as soon as any annotation fails, causing the whole batch job to be marked as failed. It is unclear if this is the desired behavior, especially when annotating a large number of manifests where partial success might be acceptable or even preferable.

Questions:

  • Should the annotation process continue for other manifests if one fails, and only report the failures at the end?
  • Should there be an option to control this behavior (e.g., --fail-fast vs. --best-effort)?
  • How should errors be reported to the user if some, but not all, annotations fail?

Action Items:

  • Decide on the desired failure policy for the annotate operation.
  • If partial success is acceptable, refactor the code to collect and report all errors, but not fail the whole job on the first error.
  • Update documentation and user messaging to reflect the chosen behavior.
  • Add tests for both fail-fast and best-effort scenarios if both are supported.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions