Make shutdown endpoint kill the backend via pid with SIGTERM #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ie process in Tauri
Collaborator
|
Nice catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to workout the sidecar thing in Tauri for @luckmer, we've discovered that calling the shutdown endpoint didn't fully close the backend. The API was still alive, as if uvicorn simply restarted the API and kept serving it.
Killing it via
os.kill(os.getpid(), signal.SIGTERM)seems to fix it, the API quits and the backend shuts down.This PR is a part of another one: EyeTrackVR/FirmwareFlashingTool#30