Skip to content

Conversation

@nmaguiar
Copy link
Collaborator

This pull request introduces several improvements and updates across the codebase, focusing on enhanced network time retrieval, improved terminal interaction handling, dependency updates, expanded documentation, and new automated tests. The most significant changes are grouped and summarized below.

Network Time Retrieval Improvements

  • Refactored ow.net.getActualTime in js/owrap.net.js to use NTP servers for accurate time retrieval, supporting custom server selection and timeout configuration. Now tries multiple public NTP servers and throws a clear error if all fail.
  • Added comprehensive automated tests for the new NTP-based time retrieval logic in tests/autoTestAll.Net.js and corresponding job definitions in tests/autoTestAll.Net.yaml. These tests cover default usage, custom server, custom timeout, and combined options. [1] [2]
  • Included the new network time tests in the global test suite by updating tests/autoTestAll.allJobs.yaml.

Terminal Interaction Enhancements

  • Improved the askChoose and askChooseMultiple functions in js/openaf.js to handle double-Escape key presses for cancellation, and made navigation wrap around the options list. Now returns a cancellation indicator (__) if the user cancels. [1] [2] [3] [4] [5] [6]

Dependency Updates

  • Updated Maven dependencies in pom.xml to newer versions for commons-codec, commons-io, and jsch, ensuring improved stability and security. [1] [2] [3]

Documentation Improvements

  • Added a new "Repository documentation" section to README.md, listing key documentation files and developer notes for easier onboarding and reference.

Miscellaneous

  • Added target-branch: "t8" to the dependabot configuration in .github/dependabot.yml to specify the target branch for dependency updates.
  • Improved error logging in src/openaf/plugins/HTTPd/JSResponse2.java by printing stack traces for better debugging.

@nmaguiar nmaguiar self-assigned this Nov 14, 2025
@nmaguiar nmaguiar added enhancement dependencies Pull requests that update a dependency file labels Nov 14, 2025
@nmaguiar nmaguiar merged commit 8e1efd5 into master Nov 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants