Feature/mi 277 migrate aspects and restructure #1573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Clearly some problems here. But I have no access to Aikido. 😢 |
Contributor
|
@ryanrixxh It's not Aikido but the error is about merge conflicts. Can you resolve those? |
…e-aspects-and-restructure
kai-nguyen-aligent
requested changes
Dec 19, 2025
Contributor
kai-nguyen-aligent
left a comment
kai-nguyen-aligent
left a comment
There was a problem hiding this comment.
Great work, @ryanrixxh 👍🏼
Just few small feedback and I think we are in a much better shape than before. It seems to me that eslint config in this repo is broken but we should address it in a different PR.
| @@ -0,0 +1,13005 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Why do we have this file here?
Contributor
There was a problem hiding this comment.
Do we need to add something in here?
Contributor
There was a problem hiding this comment.
Just curious, how come we do not have a project.json file for this package 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
After discussions with @TheOrangePuff and @kai-nguyen-aligent the MS team is migrating the CDK Aspects created for our integrations template into the CDK constructs repo.
To better organise the repository, packages have been split into two subfolders, Aspects and Constructs. So as not to make any major breaking changes to the existing packages, Nx has been configured to continue building and publishing the constructs as seperate packages on npm, whilst the aspects due to their size and to not flood the codebase with Nx related bloat are being exported as the one Nx project / npm package.
The PR seems pretty big, but the main actual additions are in the aspects folder. The rest of the changes are changes to configuration files for Nx to allow the build and publish process to operate as normal.
Surely the pipeline doesnt yell at me for this one and that everything goes smooth 🤞
Notes to PR author
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback