Enable/Make AVM_PRINT_PROCESS_CRASH_DUMPS work on embedded platforms #2049
+71
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVM_PRINT_PROCESS_CRASH_DUMPS was introduced with bcfdcc6 (PR atomvm#1799), but the option hasn't been exposed / set on embedded targets (such as esp32, stm32 and rp2). The reason is that esp32 CMakeLists.txt doesn't include the root CMakeLists.txt, and the libAtomVM one doesn't have that option defined (it is defined on the root CMakeLists.txt), so that option didn't have a default value. Signed-off-by: Davide Bettio <davide@uninstall.it>
UncleGrumpy
approved these changes
Dec 29, 2025
Collaborator
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
Look good to me. The poco_w CI failure is strange, but doesn’t seem like it is related to these changes.
CI was having some odd failures, just update it. Signed-off-by: Davide Bettio <davide@uninstall.it>
Update node and nvm script. Signed-off-by: Davide Bettio <davide@uninstall.it>
Contributor
|
see API changes here top demo/emulator-run.ts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVM_PRINT_PROCESS_CRASH_DUMPS was introduced with bcfdcc6 (PR #1799), but the option hasn't been exposed / set on embedded targets (such as esp32, stm32 and rp2).
The reason is that esp32 CMakeLists.txt doesn't include the root CMakeLists.txt, and the libAtomVM one doesn't have that option defined (it is defined on the root CMakeLists.txt), so that option didn't have a default value.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later