-
Notifications
You must be signed in to change notification settings - Fork 770
Open
Labels
Description
release.yml Trigger Configuration Analysis
Summary
Analysis of release.yml workflow configuration across all 6 WAMP Python projects.
| Project | Trigger Workflows | release-development if: condition |
runs-on |
|---|---|---|---|
| txaio | ["main"] |
release_type == 'development' || release_type == 'nightly' |
ubuntu-latest |
| autobahn-python | ["wheels", "wheels-docker", "wheels-arm64", "wstest", "main"] |
release_type == 'development' |
ubuntu-latest |
| zlmdb | ["wheels", "wheels-docker", "wheels-arm64", "main"] |
release_type == 'development' || release_type == 'nightly' |
ubuntu-latest |
| cfxdb | ["main"] |
release_type == 'development' || release_type == 'nightly' |
ubuntu-24.04 |
| wamp-xbr | ["main"] |
release_type == 'development' || release_type == 'nightly' |
ubuntu-24.04 |
| crossbar | ["main"] |
release_type == 'development' || release_type == 'nightly' |
ubuntu-24.04 |
Inconsistencies Found
1. autobahn-python missing nightly condition
Issue: autobahn-python only checks release_type == 'development', missing || release_type == 'nightly'
Current (autobahn-python):
if: |
needs.check-all-workflows.outputs.all_complete == 'true' &&
(github.event_name == 'workflow_dispatch' ||
(github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success')) &&
needs.identifiers.outputs.release_type == 'development'Should be (aligned with other projects):
if: |
needs.check-all-workflows.outputs.all_complete == 'true' &&
(github.event_name == 'workflow_dispatch' ||
(github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success')) &&
(needs.identifiers.outputs.release_type == 'development' || needs.identifiers.outputs.release_type == 'nightly')2. Trigger workflows differ (intentional)
This is expected and intentional:
- Pure Python packages (txaio, cfxdb, wamp-xbr, crossbar): Only need
["main"] - Native wheel packages (autobahn-python, zlmdb): Need multiple wheel workflows + main
3. runs-on differs
- Older configs:
ubuntu-latest - Newer configs:
ubuntu-24.04
Recommendation: Standardize on ubuntu-24.04 for consistency and explicit version control.
Action Items
- Fix autobahn-python: Add
|| release_type == 'nightly'to release-development condition - Consider standardizing
runs-on: ubuntu-24.04across all projects
Checklist
- I have searched existing issues to avoid duplicates
- I have described the problem clearly
- I have provided use cases
- I have considered alternatives
- I have assessed impact and breaking changes