Skip to content

Conversation

@LuckyXu-HF
Copy link
Contributor

For struct{single, single} case, fill and return the pData->buffer address in ProfileArgIterator::GetNextArgAddr().

…owpatheltenter.sh.

* For struct{single, single} case, fill and return the pData->buffer address in ProfileArgIterator::GetNextArgAddr().
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 23, 2025
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 23, 2025
@LuckyXu-HF
Copy link
Contributor Author

The random failed for Fp32x2StructFunc in slowpatheltenter.sh is catched on 3A6000 with output like:

slowpatheltenter.sh random failed output
BEGIN EXECUTION
/home/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Release/Tests/Core_Root//corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true slowpatheltenter.dll ''
Profiler path: /home/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Release/profiler/elt/slowpatheltenter/libProfiler.so
Profilee STDOUT: Profiler.dll!DllGetClassObject
Profilee STDOUT: Profiler.dll!Profiler::Initialize
Profilee STDOUT: Testing enter hooks
Profilee STDOUT: x=-123 y=-4.3 str=Hello, test!
Profilee STDOUT: SimpleArgsFunc returned Hello from SimpleArgsFunc!
Profilee STDOUT: ss=x=1 d=1
Profilee STDOUT: MixedStructFunc returned x=4 d=1
Profilee STDOUT: ls=x0=0 d0=0 x1=1 d1=1 x2=2 d2=2 x3=3 d3=3
Profilee STDOUT: LargeStructFunc returned 3
Profilee STDOUT: IntegerStructFunc returned x=21 y=256
Profilee STDOUT: Argument 0 for function Fp32x2StructFunc did not match.
Profilee STDOUT: Expected bytes: 9A99993F 00006040 
Profilee STDOUT: Actual bytes  : 9A99993F FF7F0000 
Profilee STDOUT: Fp32x2StructFunc returned x=1.2 y=2
Profilee STDOUT: Fp32x2StructFp32x3StructFunc returned x=6.7 y=10.11 z=13.14
Profilee STDOUT: Fp32x3StructFunc returned x=6.7 y=10.11 z=3
Profilee STDOUT: Fp32x3StructFp32x2StructFunc returned x=1.2 y=3.5
Profilee STDOUT: Fp32x3StructSingleFp32x3StructSingleFunc returned x=6.7 y=10.11 z=13.14
Profilee STDOUT: Fp32x4StructFunc returned x=15.17 y=19.21 z=22.23 w=4
Profilee STDOUT: Fp32x4StructFp32x4StructFunc returned x=15.17 y=19.21 z=22.23 w=26.29
Profilee STDOUT: Fp64x2StructFunc returned x=1.2 y=2
Profilee STDOUT: Fp64x2StructFp64x3StructFunc returned x=6.7 y=10.11 z=13.14
Profilee STDOUT: Fp64x3StructFunc returned x=6.7 y=10.11 z=3
Profilee STDOUT: Fp64x3StructFp64x2StructFunc returned x=1.2 y=3.5
Profilee STDOUT: Fp64x3StructDoubleFp64x3StructDoubleFunc returned x=6.7 y=10.11 z=13.14
Profilee STDOUT: Fp64x4StructFunc returned x=15.17 y=19.21 z=22.23 w=4
Profilee STDOUT: Fp64x4StructFp64x4StructFunc returned x=15.17 y=19.21 z=22.23 w=26.29
Profilee STDOUT: DoubleRetFunc returned 13
Profilee STDOUT: FloatRetFunc returned 13
Profilee STDOUT: IntegerSseStructFunc returned x=1 y=2 z=3.5
Profilee STDOUT: SseIntegerStructFunc returned x=1.2 y=3.5 z=6
Profilee STDOUT: MixedSseStructFunc returned x=1.2 y=3 z=5.6 w=7.1
Profilee STDOUT: SseMixedStructFunc returned x=1.2 y=3.5 z=6 w=7.1
Profilee STDOUT: MixedMixedStructFunc returned x=1.2 y=3 z=5 w=6.7
Profilee STDOUT: i=11 s1=(x=1 d=1) s2=(x=2 d=2) s3=(x=3 d=3) s4=(x=4 d=4) s5=(x=5 d=5) s6=(x=6 d=6) s7=(x=7 d=7) s8=(x=8 d=8) s9=(x=9 d=9)
Profilee STDOUT: IntManyMixedStructFunc returned x=1 d=1
Profilee STDOUT: d=11 s1=(x=1 d=1) s2=(x=2 d=2) s3=(x=3 d=3) s4=(x=4 d=4) s5=(x=5 d=5) s6=(x=6 d=6) s7=(x=7 d=7) s8=(x=8 d=8) s9=(x=9 d=9)
Profilee STDOUT: DoubleManyMixedStructFunc returned x=1 d=1
Profilee STDOUT: Profiler.dll!Profiler::Shutdown
Profilee STDOUT: TEST FAILED _failures=1
Test failed: Profiler tests are expected to contain the text 'PROFILER TEST PASSES' in the console output of the profilee app to indicate a passing test. Usually it is printed from the Shutdown() method of the profiler implementation. This text was not found in the output above. Profilee returned exit code 100.
Unhandled exception. System.Exception: Profiler tests are expected to contain the text 'PROFILER TEST PASSES' in the console output of the profilee app to indicate a passing test. Usually it is printed from the Shutdown() method of the profiler implementation. This text was not found in the output above. Profilee returned exit code 100.
   at Profiler.Tests.ProfilerTestRunner.FailFastWithMessage(String error) in /home/xuliangyu/runtime/src/tests/profiler/common/ProfilerTestRunner.cs:line 186
   at Profiler.Tests.ProfilerTestRunner.Run(String profileePath, String testName, Guid profilerClsid, String profileeArguments, ProfileeOptions profileeOptions, Dictionary`2 envVars, String reverseServerName, Boolean loadAsNotification, Int32 notificationCopies, String envVarProfilerPrefix) in /home/xuliangyu/runtime/src/tests/profiler/common/ProfilerTestRunner.cs:line 132
   at SlowPathELTTests.SlowPathELTEnter.Main(String[] args) in /home/xuliangyu/runtime/src/tests/profiler/elt/slowpatheltenter.cs:line 34
./artifacts/tests/coreclr/linux.loongarch64.Release/profiler/elt/slowpatheltenter/slowpatheltenter.sh: line 435: 1161935 Aborted                 $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}"
Expected: 100
Actual: 134
END EXECUTION - FAILED

This PR fixed the random failed with 500 times test passed.

@LuckyXu-HF
Copy link
Contributor Author

@shushanhf @jkotas could you please help to review this PR? Thanks.

Copy link
Contributor

@shushanhf shushanhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jkotas
Copy link
Member

jkotas commented Dec 23, 2025

/ba-g osx-arm64 infrastructure timeout

@jkotas jkotas merged commit 3412913 into dotnet:main Dec 23, 2025
99 of 102 checks passed
@jkotas jkotas added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 23, 2025
@LuckyXu-HF LuckyXu-HF deleted the main-LA64 branch December 24, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-loongarch64 area-Diagnostics-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants