I can't find it. I can't even find it

[passwhl]

Decorator and MethodDefinition cannot be found, only class definitions are available, others have not been tried yet

[passwhl]

"jscodeshift": "^17.1.2",

[passwhl]

I am converting the code from ionic3 to ionic7

[ElonVolo]

I believe this is the TC39 decoratorsBeforeExport issue that pops up on this list annually. Usually when someone is trying to migrate legacy ***@***.***/plugin-proposal-decorators · Babelbabeljs.ioI believe you need to pass custom parser options where you setdecoratorsBeforeExport: trueI’m out on a doordash delivery right now so I’m not able write you an example, but that’s basically how you do it.Sent from my iPhoneOn Mar 24, 2025, at 22:22, passwhl ***@***.***> wrote: image.png (view on web) image.png (view on web) image.png (view on web) image.png (view on web) image.png (view on web) Decorator and MethodDefinition cannot be found, only class definitions are available, others have not been tried yet—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> passwhl created an issue (facebook/jscodeshift#661) image.png (view on web) image.png (view on web) image.png (view on web) image.png (view on web) image.png (view on web) Decorator and MethodDefinition cannot be found, only class definitions are available, others have not been tried yet —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[passwhl]

I believe this is the TC39 decoratorsBeforeExport issue that pops up on this list annually. Usually when someone is trying to migrate legacy @./plugin-proposal-decorators · Babelbabeljs.ioI believe you need to pass custom parser options where you setdecoratorsBeforeExport: trueI’m out on a doordash delivery right now so I’m not able write you an example, but that’s basically how you do it.Sent from my iPhoneOn Mar 24, 2025, at 22:22, passwhl @.> wrote:
image.png (view on web)
image.png (view on web)
image.png (view on web)
image.png (view on web)
image.png (view on web)
Decorator and MethodDefinition cannot be found, only class definitions are available, others have not been tried yet—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

passwhl created an issue (facebook/jscodeshift#661)
image.png (view on web)
image.png (view on web)
image.png (view on web)
image.png (view on web)
image.png (view on web)
Decorator and MethodDefinition cannot be found, only class definitions are available, others have not been tried yet

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

I am using custom parsing and have written all the plugins that can be written, but I still cannot recognize them

[pass-wang]

I reorganized it to see more clearly.

[ElonVolo]

Sharing the screenshot involves a lot of extra typing on the part of the maintainers to recreate your problem.The easiest way to get help with your issues with jscodeshift is to set up the tiniest project you can that contains the smallest complete example of the codemod and the code it’s transforming, which reproduces the problem with the least amount of code as possible. And also include an example of what you expect the end result of the transformed to look like. And then share all that as a git repository that we maintainers can clone and play around with.Sent from my iPhoneOn Mar 26, 2025, at 21:21, pass-wang ***@***.***> wrote: image.png (view on web) image.png (view on web) I reorganized it to see more clearly.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***> pass-wang left a comment (facebook/jscodeshift#661) image.png (view on web) image.png (view on web) I reorganized it to see more clearly. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

[pass-wang]

file test.ts ===>

import { Component } from "@angular/core";
import { IonicPage, NavController, NavParams } from "ionic-angular";

@IonicPage()
@Component({
    selector: "page-test",
    templateUrl: "test.html"
})
export class TestPage {
    constructor(public navCtrl: NavController, public navParams: NavParams) {}

    ionViewDidLoad() {
        console.log("ionViewDidLoad TestPage");
    }

    async ionViewWillEnter() {
        console.log("Page will enter");
    }

    navigate() {
        this.navCtrl.push("DetailPage");
    }
}

file jscode.js ===>

const {run: jscodeshift} = require('jscodeshift/src/Runner')
const path = require('node:path');

(async function main() {    
    const transformPath = path.resolve('jscode.transform.js')
    const paths = ['test.ts']
    const options = {dry: false, print: false, verbose: 1,extensions:'ts'}
    await jscodeshift(transformPath, paths, options)
})().then();

jscode.parser.js ===>

'use strict';
const babylon = require('@babel/parser');
module.exports = function() {
  return {
    parse(code) {
      return babylon.parse(code, {
        sourceType: 'module',
        allowImportExportEverywhere: true,
        allowReturnOutsideFunction: true,
        startLine: 1,
        tokens: true,
        plugins: [
          // ['flow', {all: true}],
          // 'flowComments',
          'typescript',
          'jsx',
          'asyncGenerators',
          'bigInt',
          'classProperties',
          'classPrivateProperties',
          'classPrivateMethods',
          ['decorators', {decoratorsBeforeExport: true}],
          'doExpressions',
          'dynamicImport',
          'exportDefaultFrom',
          'exportNamespaceFrom',
          'functionBind',
          'functionSent',
          'importMeta',
          'logicalAssignment',
          'nullishCoalescingOperator',
          'numericSeparator',
          'objectRestSpread',
          'optionalCatchBinding',
          'optionalChaining',
          ['pipelineOperator', {proposal: 'minimal'}],
          'throwExpressions',
        ]
      });
    }
  };
};

file jscode.transform.js ===>

const getParser = require("./jscode.parser");
module.exports = function(fileInfo, api, options) {
  console.info(options);
  const j = api.jscodeshift;
  const root = j(fileInfo.source);
  console.info("Decorator",root.find(j.Decorator).size())
  console.info("MethodDefinition",root.find(j.MethodDefinition).size())
  console.info("ClassDeclaration",root.find(j.ClassDeclaration).size())
  return root.toSource();
};

module.exports.parser = getParser();

Decorator and MethodDefinition should not be 0, but they are 0

[pass-wang]

recreate

[ElonVolo]

It turns out it's (yet once again) an ast-types issue, in this case where ast-types doesn't support fully support decorators yet due to what looks like a visitor issue. Visitors are the thing that makes jscodeshift's find() function work.

UnrefinedBrain/vue-upgrade-tool#2

benjamn/ast-types#694

The decorators are there but you'll have to pluck them manually from the objects.