Skip to content

These look great! Just a few notes: #41972

@bosniltd-a11y

Description

@bosniltd-a11y

These look great! Just a few notes:

  • Please don't eliminate the option to run http://localhost:8080 as it's handy to run the server without additional installs (caddy).
  • I'd suggest duplicating localhost.config.json to a new rp-local.config.json.
  • How about rp.localhost and idp.localhost for shorter server name?
  • Let's move hardcoded IdP setting in identity-providers.ts to config files. We can do this in another pull request, or I can work on it.

Originally posted by @agektmr in GoogleChromeLabs/project-sesame#27 (review)

Metadata

Metadata

Assignees

No one assigned

    Labels

    triageDo not begin working on this issue until triaged by the team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions