[BUG] legacy default theme not updated after upgrade

[tanty]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

At

docker-piwigo/root/etc/s6-overlay/s6-rc.d/init-piwigo-config/run

Line 48 in 9c57b84

symlinks=(

We are symlinking our local themes on top of the installed themes by piwigo.

IIUC, the root idea is that we can drag along custom installed themes. This is fine but, unfortunately, piwigo also stores other content, including the "default" theme, in that folder which receives updates from version to version:
https://github.com/Piwigo/Piwigo/tree/master/themes

If we symlink without having this into account, we end having the content of our older piwigo installation still in "themes" after an upgrade.

Expected Behavior

No response

Steps To Reproduce

N/A

Environment

- OS: Debian stable
- How docker service was installed: podman from distro's packagemanager

CPU architecture

x86-64

Docker creation

N/A

Container logs

N/A

[tanty]

FWIW, this problem also exists for the other symlinked directories, but the content there has not been updated in the last 6 years and, hence, has not become a problem yet.

[tanty]

I also wonder about the need to symlink the themes directory since Piwigo provides the themes_dir configuration variable.

[tanty]

Please, consider also:

• Not possible to use custom themes directory  Piwigo/Piwigo#1978

[mossroy]

Could it be the reason why the login page displays the following error with version 16.0.0-ls322? (and was OK with 15.7.0-ls319)

Warning: filemtime(): stat failed for ./themes/standard_pages/theme.css in /app/www/public/include/template.class.php on line 1925

[veletron2]

Could it be the reason why the login page displays the following error with version 16.0.0-ls322? (and was OK with 15.7.0-ls319)

Warning: filemtime(): stat failed for ./themes/standard_pages/theme.css in /app/www/public/include/template.class.php on line 1925

I have this same error after upgrading beyond V15.7.0-ls322 I have no idea whether the underlying cause is as described in this thread, so I will raise it as a separate issue.

[zero0cool0]

Same issue here. As a band-aid, I've created my own Docker build based on linuxserver/piwigo:latest and I'm copying the standard_pages to the themes folder during the build. Clearly not the ideal and final solution, but working for now.

[thespad]

I'm going to try and find time this weekend to address this, sorry for the delay.

[veletron2]

I'm going to try and find time this weekend to address this, sorry for the delay.

No apology needed. If I was any good at this stuff I would offer to assist! I raised as separate issue as was not sure if they were related.