[Suggestion] Make graylist configurable via config/add support for other permission plugins

[Quik2007]

Hi! I want to use Vane on a server with Luckperms and would like to use the Graylist feature without switching permission plugin.

Is there any chance to add "normal" config options and permissions for vane-admin for the graylist feature and not require the use of vane-permissions?

E.g. players need to have vane.admin.vouch to be able to use /vouch with a section like this:

graylist:
  enable: false
  
  command_vouch:
    # Enable command vouch for players with vane.admin.vouch permission
    # Default: true
    enabled: true

I don't know whether it is possible for Vane to add graylisted players to some permission group and allow interoperability with existing permission plugins though, so I'd be happy to hear from you.

[Quik2007]

As far as I can tell not supporting other permission plugins for this feature was so you could work with the default hasPermission API and wouldn't have to implement vanes-permissions as a full Vault permissions provider only to then use the Vault API in order to be able to add the player to a permission group.
There are multiple ways around this, maybe one could use the Vault API as a fallback if vane-permissions isn't present? That way, vane-permissions could stay very simple, but use cases like mine would still work.
This would involve a certain amount of code duplication/Vault boilerplate, but Vault isn't dead (or at least forks like VaultUnlocked aren't), so maybe it could be worth it.

Maybe I can come around to submit a PR in a week or two if you'd be interested and thank you so much for the great plugin!

[oddlama]

As far as I can tell not supporting other permission plugins for this feature was so you could work with the default hasPermission API and wouldn't have to implement vanes-permissions as a full Vault permissions provider only to then use the Vault API in order to be able to add the player to a permission group.

Partly, yes. This feature was mostly born out of a need back when I didn't anticipate making vane a public project. It only has vane-permissions integration because that was all I needed at that time and there was no reason yet to introduce an abstraction layer.

There are multiple ways around this, maybe one could use the Vault API as a fallback if vane-permissions isn't present? That way, vane-permissions could stay very simple, but use cases like mine would still work. This would involve a certain amount of code duplication/Vault boilerplate, but Vault isn't dead (or at least forks like VaultUnlocked aren't), so maybe it could be worth it.

Certainly, sounds like a good plan! I believe we already introduced Vault a while back for some economy stuff where people wanted economy plugin integration. I didn't actually know it had an abstraction for permission groups and crucially modification of player permissions :D

Maybe I can come around to submit a PR in a week or two if you'd be interested and thank you so much for the great plugin!

Looking forward to it!