This repository was archived by the owner on Jan 31, 2019. It is now read-only.
pcre: create binconfig-recipe instead of inheriting binconfig class #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pcre package creates a pcre-config script used by dependent packages
during their configure step. The this shell script is created in machine
context, it must be made available to dependent packages during their
stage step.
Until now, this was done by letting the pcre recipe inherit the
binconfig class, which adds a call to binconfig_stage_fixup() during the
dependent stage step. However, binconfig_stage_fixup() symlinks into
./stage/cross/bin/, which is not "allowed" in the stage fixup functions.
(They should only touch ./stage.unpack/ and not ./stage ).
Also, the symlink-during-stage fixup approach might fail as
./stage/cross/bin is not guarenteed to be created when
binconfig_stage_fixup() is called.
Fix this mess by creating a whole new recipe (pcre-binconfig) which
installs the symlink in cross context, and add is a dependency to the
libpcre package.