From 71e21c64eb4c000be1bae67a3da435ac95dd2180 Mon Sep 17 00:00:00 2001 From: "Daniel (dB.) Doubrovkine" Date: Tue, 30 Dec 2025 13:09:24 -0500 Subject: [PATCH] Migrate Danger to use danger-pr-comment workflow. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 --- .github/workflows/danger-comment.yml | 11 +++++++++++ .github/workflows/danger.yml | 13 +++++++++++++ .github/workflows/pr_lint.yml | 21 --------------------- CHANGELOG.md | 1 + Dangerfile | 5 ++++- Gemfile | 3 +++ Gemfile.danger | 6 ------ 7 files changed, 32 insertions(+), 28 deletions(-) create mode 100644 .github/workflows/danger-comment.yml create mode 100644 .github/workflows/danger.yml delete mode 100644 .github/workflows/pr_lint.yml delete mode 100644 Gemfile.danger diff --git a/.github/workflows/danger-comment.yml b/.github/workflows/danger-comment.yml new file mode 100644 index 00000000..87aa9edf --- /dev/null +++ b/.github/workflows/danger-comment.yml @@ -0,0 +1,11 @@ +name: Danger Comment + +on: + workflow_run: + workflows: [Danger] + types: [completed] + +jobs: + comment: + uses: numbata/danger-pr-comment/.github/workflows/danger-comment.yml@v0.1.0 + secrets: inherit \ No newline at end of file diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml new file mode 100644 index 00000000..bf1c19ff --- /dev/null +++ b/.github/workflows/danger.yml @@ -0,0 +1,13 @@ +name: Danger + +on: + pull_request: + types: [opened, reopened, edited, synchronize] + +jobs: + danger: + uses: numbata/danger-pr-comment/.github/workflows/danger-run.yml@v0.1.0 + secrets: inherit + with: + ruby-version: '4.0' + bundler-cache: true diff --git a/.github/workflows/pr_lint.yml b/.github/workflows/pr_lint.yml deleted file mode 100644 index dc799b8c..00000000 --- a/.github/workflows/pr_lint.yml +++ /dev/null @@ -1,21 +0,0 @@ -name: PR Lint -on: pull_request -jobs: - danger: - name: Dangerfile - runs-on: ubuntu-latest - env: - BUNDLE_GEMFILE: ${{ github.workspace }}/Gemfile.danger - steps: - - name: Checkout - uses: actions/checkout@v6 - with: - fetch-depth: 0 - - name: Set up Ruby - uses: ruby/setup-ruby@v1 - with: - bundler-cache: true - - run: | - # Personal access token for dangerpr-bot - public, but base64 encoded to avoid tripping up GitHub - TOKEN=$(echo -n Z2hwX0xNQ3VmanBFeTBvYkZVTWh6NVNqVFFBOEUxU25abzBqRUVuaAo= | base64 --decode) - DANGER_GITHUB_API_TOKEN=$TOKEN bundle exec danger --verbose diff --git a/CHANGELOG.md b/CHANGELOG.md index b57ba437..7b1dc81f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ### 3.1.1 (Next) +* [#581](https://github.com/slack-ruby/slack-ruby-client/pull/581): Migrate Danger to use danger-pr-comment workflow - [@dblock](https://github.com/dblock). * Your contribution here. ### 3.1.0 (2025/11/15) diff --git a/Dangerfile b/Dangerfile index 10c6cd21..b4bc3669 100644 --- a/Dangerfile +++ b/Dangerfile @@ -1,3 +1,6 @@ # frozen_string_literal: true -danger.import_dangerfile(gem: 'slack-ruby-danger') +danger.import_dangerfile(gem: 'danger-pr-comment') + +changelog.check! +toc.check! diff --git a/Gemfile b/Gemfile index b3dd3109..ccc186e4 100644 --- a/Gemfile +++ b/Gemfile @@ -7,6 +7,9 @@ group :test do gem 'activesupport' gem 'base64' gem 'bigdecimal' + gem 'danger-changelog', require: false + gem 'danger-pr-comment', require: false + gem 'danger-toc', require: false gem 'erubis' gem 'faraday-typhoeus' gem 'json-schema' diff --git a/Gemfile.danger b/Gemfile.danger deleted file mode 100644 index b2f7ef84..00000000 --- a/Gemfile.danger +++ /dev/null @@ -1,6 +0,0 @@ -source 'https://rubygems.org' - -group :test do - gem 'danger-toc', '~> 0.2.0', require: false - gem 'slack-ruby-danger', '~> 0.2.0', require: false -end