isolate problem of rogue 403 errors #769
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Forbiddenmessage on logout (and elsewhere) was caused by:accesson the user model is[])ensureAuthenticatedmodule is also apparently doing some authorization--- if the user'saccessis empty, it denies the request with a403. This is applied to the whole API, including the stuff on the user dashboard.This at least illustrates the problem by changing the user creation logic to include a default access; if you pull this branch and make a new user, the rogue
Forbiddens go away. That's not to say this is a solution--- seems like finer grained access control might be the answer there. But in the meantime we know what it is and can kludge it if necessary. (Still marking as a draft to prevent accidental merge)I also changed a couple things in the setup for local dev, can always do those in a separate PR though.