Skip to content

Conversation

@michael-oberpriller
Copy link

No description provided.

@kdj0c
Copy link
Collaborator

kdj0c commented Sep 21, 2025

Thanks for your MR, that looks good to me!

The pipeline fails, because you also need to update the call to tsm_screen_draw() in src/gtktsm/gtktsm-terminal.c

../src/gtktsm/gtktsm-terminal.c:1055:21: error: too few arguments to function ‘tsm_screen_draw’
1055 | rend->age = tsm_screen_draw(ctx->screen,

Also This breaks backward compatibility (an old version of kmscon won't work with a new version of libtsm).
Let me some time to think if we can find a way to not break the API.

@michael-oberpriller
Copy link
Author

The pipeline fails, because you also need to update the call to tsm_screen_draw() in src/gtktsm/gtktsm-terminal.c

../src/gtktsm/gtktsm-terminal.c:1055:21: error: too few arguments to function ‘tsm_screen_draw’ 1055 | rend->age = tsm_screen_draw(ctx->screen,

I added double width support to Gtktsm, so this should be fixed now.

@dimitry-ishenko
Copy link

@kdj0c @michael-oberpriller There is no need to break the ABI IMHO. I've figured out a way to emulate what most major terminals do (as shown in Aetf/kmscon#18). In fact, no changes are needed for libtsm. I will submit a PR shortly.

@dimitry-ishenko
Copy link

@michael-oberpriller @kdj0c please see Aetf/kmscon#136. Hopefully one of you can find it useful to do proper implementation.

@michael-oberpriller
Copy link
Author

These changes have been implemented in Aetf/kmscon#135.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants