Skip to content

Conversation

@maxreinartz
Copy link
Contributor

@maxreinartz maxreinartz commented Dec 24, 2025

Changes

  • Added a bar to the progress bar which shows the buffered progress
  • Updates mute functionality to save the volume prior to the mute
  • Updated player controls to use global volume, the new muted functionality
  • Update audio mode to use full screen area
  • Minor tweaks to iOS video player and full screen
  • Added keybinds for fullscreen (F), toggling audio mode (A), toggling PIP (P)
  • Added keyboard shortcuts menu and toggle pip button to video player overlay
Screenshot 2025-12-26 151755

@maxreinartz maxreinartz changed the title Updates to Video Player Bar Updates to Video Player Dec 26, 2025
@maxreinartz maxreinartz marked this pull request as draft December 29, 2025 03:57
@maxreinartz maxreinartz marked this pull request as ready for review December 29, 2025 04:48
@maxreinartz
Copy link
Contributor Author

This is what the keyboard shortcuts menu looks like. Let me know if there is a better way to style it.

image

@Maniload
Copy link
Member

Looks good 👍 I might make some minor adjustments when I get to reviewing. Btw should I already do that? I've seen you are still pushing changes, so I've been waiting for now.

@maxreinartz
Copy link
Contributor Author

I've done all the changes I was planning so you can check it when you want 👍.
Thanks!

@maxreinartz
Copy link
Contributor Author

Changed some of the hotkeys to be the same as Youtube
. -> L (seek forward large)
, -> J (seek backward large)

Basic single frame seeks (assumes fps is 24)
. -> one frame forward
, -> one frame back

I did not test though (changed this on my phone)

@Maniload
Copy link
Member

Maniload commented Jan 5, 2026

I made some visual changes. Let me know if you don't like them ^^

I also had to move the keyboard input function a bit lower, because my linter told me to convert two functions to use useCallback, so they could no longer be hoisted.

Apart from that, I think this is good and can be merged 👍

image image

@maxreinartz
Copy link
Contributor Author

LGTM 👍

@Maniload Maniload merged commit 74a9aff into AnimeThemes:main Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants