Skip to content

feat: Implement session replay tool. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rushabhshroff merged 1 commit into from
Dec 18, 2025
Merged

feat: Implement session replay tool. #3

Rushabhshroff merged 1 commit into from
Dec 18, 2025

Conversation

@Rushabhshroff
Copy link
Collaborator

@Rushabhshroff Rushabhshroff commented Dec 18, 2025

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 18, 2025
View reviewed changes
src/utils/text-logs-parser.ts
Comment on lines +129 to +130
pPath
.replace(/\//g, "\\/")

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This does not escape backslash characters in the input.

Copilot Autofix

AI 7 days ago

To fix the incomplete string escaping, add an additional .replace(/\\/g, "\\\\") call before the existing .replace(/\//g, "\\/") sequence on pPath. This ensures that any backslash is properly escaped when building the regex, preventing malformed patterns or potential vulnerabilities if the set of command map keys changes in the future. Only edit the chain of .replace calls inside the resolveCommandName function, at the construction of the regex source string.

No new methods or imports are needed, as this is a mechanical and standard string operation.

Suggested changeset 1
src/utils/text-logs-parser.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/utils/text-logs-parser.ts b/src/utils/text-logs-parser.ts
--- a/src/utils/text-logs-parser.ts
+++ b/src/utils/text-logs-parser.ts
@@ -127,6 +127,7 @@
         const regex = new RegExp(
             "^" +
             pPath
+                .replace(/\\/g, "\\\\")
                 .replace(/\//g, "\\/")
                 .replace(/:sessionId/g, "[^/]+")
                 .replace(/:id/g, "[^/]+")
EOF
@@ -127,6 +127,7 @@
const regex = new RegExp(
"^" +
pPath
.replace(/\\/g, "\\\\")
.replace(/\//g, "\\/")
.replace(/:sessionId/g, "[^/]+")
.replace(/:id/g, "[^/]+")
Copilot is powered by AI and may make mistakes. Always verify output.
@Rushabhshroff Rushabhshroff merged commit 168810a into main Dec 18, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saqibganaie saqibganaie saqibganaie approved these changes

@Adarsh2692 Adarsh2692 Awaiting requested review from Adarsh2692

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rushabhshroff @saqibganaie