Skip to content

Develop #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
psomhorst wants to merge 30 commits into from
Closed

Develop #371

psomhorst wants to merge 30 commits into from

Conversation

@psomhorst
Copy link
Contributor

@psomhorst psomhorst commented May 15, 2025

No description provided.

psomhorst and others added 30 commits April 28, 2025 19:38
@psomhorst
Merge branch 'main' into develop
333729e
@psomhorst
Update documentation to fix list layout
6123367
@psomhorst
Merge pull request #368 from EIT-ALIVE/fix_documentation
d05fd52 
Update documentation to fix list layout
@psomhorst
Fix pixels being ignored when absolute value negative
d39a815 
Pixels are now skipped when they have no amplitude, i.e. when the standard deviation equals 0.
@psomhorst
Add boolean option to allow pixels with negative amplitude
07f0c90
@psomhorst
Make allow_negative_amplitude class attribute
367d3e0
@psomhorst
Make allow_negative_amplitude True by default
98ef67e
@psomhorst
Replace breath_detection_kwargs in TIV and PixelBreath with BreathDet…
8382461 
…ection object
@psomhorst
Add documentation for new argument
0dfee24
@psomhorst
Fix linting issues
ab67491
@psomhorst
Add exception for providing wrong TIV method
67da634
@psomhorst
Update tests
7b35415
@psomhorst
Re-add breath_detection_kwargs argument with DeprecationWarning
a26e490
@psomhorst
Remove unused imports
480ba5b
@psomhorst
Replace breath_detection_kwargs in EELI with breath_detection
fb89764
@psomhorst
Update EELI tests
189600a
@psomhorst
Update pixel_breath to consider phase shift
62ced5f
@psomhorst
Copy potentially non-writeable array
adb9e10
@psomhorst
Fix grammar issues
70423ce
@psomhorst
Make PixelBreath keyword-only
aa65186
@psomhorst
Replace competing boolean arguments with mode argument
cc1518a
@psomhorst
Update documentation to match new PixelBreath workings
cee67e3
@psomhorst
Fix existing test with short data resulting in all None values
de4db42
@psomhorst
Add test for different phase corrections modes
3178504
@psomhorst
Fix linting issues
b210653
@psomhorst
Fix sentinel spelling
06e0c57
@psomhorst
Fix selecting short time with too few breaths
9237110
@psomhorst
Fix runtime warning for empty slices
0c495b4
@psomhorst
Catch or fix deprecation warnings in tests
12be567
@psomhorst
Merge pull request #369 from EIT-ALIVE/fix_pixel_breath_negative_tiv
639d76b 
Fix pixel breath detection for pixels with negative TIV.
@psomhorst psomhorst closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@psomhorst