Fix pixel breath cross correlation issue #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psomhorst
force-pushed
the
fix/462-pixel-breath-cross-correlation
branch
from
abdeba5 to
30c6591
Compare
psomhorst
force-pushed
the
fix/462-pixel-breath-cross-correlation
branch
from
30c6591 to
dc5b1f1
Compare
JulietteFrancovich
approved these changes
Dec 10, 2025
Contributor
JulietteFrancovich
left a comment
JulietteFrancovich
left a comment
There was a problem hiding this comment.
I think this fix is ok but I would indeed suggest expanding the warning to indicate that the user might want to inspect the pixel signal to check for stability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix for the issue covered in #462.
The example resulted in no peaks found in the cross correlation. This fix skips pixels where no peaks are found in the cross correlation.
I added a warning about skipping pixels. We could discuss whether we want to expand this warning to indicate that the section might not be stable (when no cross correlation is found, that's probably due to large non-respiratory changes).
Fixes #462.