Skip to content

feature/20-dev-gRPC #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qkrwndnjs1075 merged 5 commits into from
Aug 1, 2025
Merged

feature/20-dev-gRPC #24

qkrwndnjs1075 merged 5 commits into from
Aug 1, 2025

Conversation

@qkrwndnjs1075
Copy link
Member

@qkrwndnjs1075 qkrwndnjs1075 commented Jul 28, 2025

  • gRPC 관련 비즈니스 로직 PR

@qkrwndnjs1075 qkrwndnjs1075 self-assigned this Jul 28, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 28, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/20-dev-gRPC

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

0xC0FFE2
0xC0FFE2 requested changes Jul 29, 2025
View reviewed changes
casper-user/src/main/kotlin/hs/kr/entrydsm/user/infrastructure/grpc/server/UserGrpcService.kt
} catch (e: Exception) {
throw StatusException(Status.INTERNAL.withDescription("서버 오류"))
}
}
Copy link
Contributor

@0xC0FFE2 0xC0FFE2 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왜 에러가 한국어였다가 영어였다가 계속 바뀌나요 @qkrwndnjs1075

Copy link
Member Author

@qkrwndnjs1075 qkrwndnjs1075 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에러 처리는 비즈니스 로직 상에서 처리 되어지고 있기 때문에 제거 하였습니다.

Copy link
Contributor

@0xC0FFE2 0xC0FFE2 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

Copy link
Member Author

@qkrwndnjs1075 qkrwndnjs1075 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6d54dd7

...user/src/main/kotlin/hs/kr/entrydsm/user/infrastructure/grpc/server/mapper/UserGrpcMapper.kt
* @return gRPC 사용자 정보 응답
*/
fun toGetUserInfoResponse(userResponse: InternalUserResponse): UserServiceProto.GetUserInfoResponse {
return UserServiceProto.GetUserInfoResponse.newBuilder()
Copy link
Contributor

@0xC0FFE2 0xC0FFE2 Jul 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.setReceiptCode() 이것도 추가해야 하는거 아닌가요 @qkrwndnjs1075

Copy link
Member Author

@qkrwndnjs1075 qkrwndnjs1075 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 ?: 0L이 맞나 수험번호를 부여 받는 건데?

Copy link
Contributor

@0xC0FFE2 0xC0FFE2 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

서버팀에서 판단 하시죠

Copy link
Member Author

@qkrwndnjs1075 qkrwndnjs1075 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 생각해보니까 어짜피 receiptCode는 안 보내서 필요없음

Copy link
Contributor

@0xC0FFE2 0xC0FFE2 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@0xC0FFE2 0xC0FFE2 self-requested a review July 29, 2025 08:38
@qkrwndnjs1075 qkrwndnjs1075 merged commit 8652395 into main Aug 1, 2025
1 check passed
@qkrwndnjs1075 qkrwndnjs1075 deleted the feature/20-dev-gRPC branch August 1, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xC0FFE2 0xC0FFE2 0xC0FFE2 approved these changes

@coehgns coehgns coehgns approved these changes

@kangeunchan kangeunchan Awaiting requested review from kangeunchan

Assignees

@qkrwndnjs1075 qkrwndnjs1075

Labels

Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qkrwndnjs1075 @0xC0FFE2 @coehgns