Skip to content

Conversation

@L03TJ3
Copy link
Contributor

@L03TJ3 L03TJ3 commented Oct 30, 2025

Description

@gooddollar/goodprotocol bump for xdc prod contracts

About # (link your issue here)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

Description by Korbit AI

What change is being made?

Bump the protocol package by updating @gooddollar/goodprotocol from ^2.0.34-beta.1 to ^2.1.0 in package.json to support xdc production contracts.

Why are these changes being made?

Upgrade to a newer protocol version to align with xdc prod contract requirements and ensure compatibility and stability.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this rooster.

   \\
   (o>
\\_//)
 \_/_)
  _|_

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Review the @gooddollar/goodprotocol 2.1.0 changelog for breaking changes and ensure compatibility with your XDC production contract interfaces.
  • Update any deployment or CI configurations that still reference the previous beta version to use @gooddollar/goodprotocol 2.1.0.
  • Confirm that the contract addresses and ABIs in the XDC production environment align with the bumped protocol version.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Review the @gooddollar/goodprotocol 2.1.0 changelog for breaking changes and ensure compatibility with your XDC production contract interfaces.
- Update any deployment or CI configurations that still reference the previous beta version to use @gooddollar/goodprotocol 2.1.0.
- Confirm that the contract addresses and ABIs in the XDC production environment align with the bumped protocol version.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sirpy sirpy merged commit 73d48a2 into master Oct 30, 2025
11 checks passed
@sirpy sirpy deleted the xdc-prod-contracts branch October 30, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants