Update CompanySettings.java #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(model): Resolve StackOverflowError in CompanySettings/GeneralPreferences toString() A java.lang.StackOverflowError was occurring during the processing (likely serialization or logging) of CompanySettings and GeneralPreferences objects. The issue was identified as an infinite recursion between their respective 'toString()' methods. This recursion stemmed from Lombok's @DaTa annotation, which automatically generates toString() methods that attempt to include all fields. Since CompanySettings references GeneralPreferences, and GeneralPreferences (inferred) references CompanySettings, their toString() calls would loop endlessly. This commit resolves the issue by adding @ToString.Exclude to the fields causing the circular dependency: - 'generalPreferences' field in CompanySettings.java - (Assuming) 'companySettings' field in GeneralPreferences.java This change prevents the problematic fields from being included in the generated toString() output, thereby breaking the recursive call chain and eliminating the StackOverflowError.
👷 Deploy request for jade-gingersnap-11da58 pending review.Visit the deploys page to approve it
|
Author
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(model): Resolve StackOverflowError in CompanySettings/GeneralPreferences toString()
A java.lang.StackOverflowError was occurring during the processing (likely serialization or logging) of CompanySettings and GeneralPreferences objects. The issue was identified as an infinite recursion between their respective 'toString()' methods.
This recursion stemmed from Lombok's @DaTa annotation, which automatically generates toString() methods that attempt to include all fields. Since CompanySettings references GeneralPreferences, and GeneralPreferences (inferred) references CompanySettings, their toString() calls would loop endlessly.
This commit resolves the issue by adding @ToString.Exclude to the fields causing the circular dependency:
This change prevents the problematic fields from being included in the generated toString() output, thereby breaking the recursive call chain and eliminating the StackOverflowError.