Fix "make distcheck" #114
Open
Fix "make distcheck" #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments relevant only to Makefile.am do *not* belong in Makefile.in.
These files were removed in 98b859f
The built in rule causes testprog.out to be overwritten by a libtool wrapper script, which is not desired behavior.
Contributor
|
There's already a test for this in https://github.com/HEASARC/cfitsio/blob/develop/.github/workflows/ci.yml, so there's some redundancy here with your |
wrp
force-pushed
the
add-check-target
branch
2 times, most recently
from
f2b661a to
f528033
Compare
Contributor
|
Thank you for adding the modifications to the ci.yml. 👍 |
wrp
force-pushed
the
add-check-target
branch
from
f528033 to
23d127d
Compare
Users of autoconfiscated packages expect to be able to run "make check" to run the test suite.
wrp
force-pushed
the
add-check-target
branch
from
23d127d to
204543c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'distcheck' recipe should work, and it should execute the test suite. This PR adds a wrapper script to invoke testprog and adds all the necessary source files to the distribution tarball so that the distcheck target can run.
This PR stacks on #113. Since all of the autotool meta-data files are included in the repository, the diff appears significant, but this is just few lines in Makefile.am and the addition of the run-test script.