-
Notifications
You must be signed in to change notification settings - Fork 0
Ingesting the introduction to IXPE data analysis notebook from SciServer cookbooks #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DavidT3
wants to merge
15
commits into
main
Choose a base branch
from
notebook/ingestIXPEDemoNotebookSciServer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the repo structure, also added an ixpe index file, and pointed to it in the top-level index file. For issue #110
… notebook. The learning goals, intro, imports, and constant/config cells are populated. Along with the notebook metadata and the additional resources section. For issue #110
…m the original notebook as it was designed for SciServer. For issue #110
… - extraction/fitting of detector 2 and 3 spectra is not included as we will parallelize them in a second. For issue #110
… in of the spectra into pyxspec. Saves changing directory into the out_path and then having moved away from the original workding directory (which personally I think is always dangerous). For issue #110
…aking it a little nicer to look at and cutting down on repeated expressions. Also improved the figure aethsetics. For issue #110
…dding more subheaders. For issue #110
…book. Also added a few more informative prints of variables etc, for educational purposes. For issue #110
…ugh the entire thing and added more commentary and explanation, cleaned up bits and bobs etc. Would be good to get it reviewed by someone who knows something more about IXPE. For issue #110 (should put it into review).
Collaborator
Author
|
Hi Kavitha, I've sent you an invitation to the HEASARC GitHub organization, and when you accept it I will be able to add you as a reviewer on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc-content
Changes or additions to the content of the documentation
mission-specific
Issues that relate to a single high-energy mission
ready-for-review
HEASARC internal review process can begin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first pass at ingestion of the IXPE introduction notebook from sci-server into HEASARC-tutorials. It has been transplanted into the format required by HEASARC-tutorials, verified to run on Fornax directly, and had some improvements to the code/readability of the code.
Some of the text has been modified by myself, as has the structure. More editing of the text and narrative is likely required to finish it off.
Concerned this notebook may not run on CI/CD because of the less common XSPEC models that it fits
HEASARC notebook review template
Critical review criteria
The author of the pull request should make an effort to go through these check points and ensure that their submission satisfies each point - reviewers will also compare to these checklists.
Science review checklist
Formatting checklist
Tech review checklist
try/exceptstatements that are narrow in scope?