vscode-eslint-language-server v3.0.20 (new formula) #259385
Conversation
github-actions
bot
added
nodejs
ALX99
force-pushed
the
eslint-language-server
branch
from
9ed8f94 to
8872123
Compare
ALX99
changed the title
ALX99
force-pushed
the
eslint-language-server
branch
from
8872123 to
569b1a5
Compare
ALX99
changed the title
ALX99
changed the title
ALX99
force-pushed
the
eslint-language-server
branch
5 times, most recently
from
de89d10 to
75f7b49
Compare
| class VscodeEslintLanguageServer < Formula | ||
| desc "ESLint language server from VSCode" | ||
| homepage "https://github.com/microsoft/vscode-eslint" | ||
| url "https://github.com/microsoft/vscode-eslint/archive/refs/tags/release/3.0.20.tar.gz" |
There was a problem hiding this comment.
Sorry, please clarify. There is no NPM package
There was a problem hiding this comment.
ah, I thought it should have some npm package for this to install, let me run another check
| system "npm", "ci" | ||
| system "npm", "run", "compile:server" | ||
|
|
||
| libexec.install Dir["*"] | ||
|
|
||
| # Create a wrapper script that explicitly invokes node with the server script | ||
| (bin/"vscode-eslint-language-server").write <<~EOS | ||
| #!/usr/bin/env bash | ||
| exec "#{Formula["node"].opt_bin}/node" "#{libexec}/server/out/eslintServer.js" "$@" | ||
| EOS |
There was a problem hiding this comment.
check out other node formulae
There was a problem hiding this comment.
Please elaborate a bit more, vscode-eslint does not provide a binary by default so I think we have to create a wrapper script like this
There was a problem hiding this comment.
can you provide the current upstream installation methods?
There was a problem hiding this comment.
Other than than of what is mentioned in the README there are none I believe. The language server is bundled together with the vscode plugin and not provided separately and majority of people just click the install button in vscode.
There is another brew package here that also tries to address this issue by repackaging the language servers from vscode as a separate NPM package. However, ideally I would not like to have to rely on this one as already it seems like it's not being updated and is not controlled by the vscode maintainers.
What I'm trying to do for this formula is the same way the Arch package maintainers are doing here. (Cloning the official repo, compiling the server and providing it as a standalone binary for editors other than vscode which rely on LSPs)
github-actions
bot
added
the
autosquash
ALX99
force-pushed
the
eslint-language-server
branch
9 times, most recently
from
a5a0a79 to
b1a71fe
Compare
github-actions
bot
removed
the
autosquash
… Server Add a new formula to provide the Language Server Protocol implementation for ESLint from the official vscode-eslint repository. This allows editor integration with ESLint through LSP-compatible editors. Co-authored-by: Rui Chen <rui@chenrui.dev>
ALX99
force-pushed
the
eslint-language-server
branch
from
b1a71fe to
ddda1e2
Compare
2 participants
Description
Adds a new formula for vscode-eslint-language-server
Verification
brew install --build-from-source vscode-eslint-language-server.rbbrew audit --strict --new vscode-eslint-language-server.rbbrew test vscode-eslint-language-server.rbDetails