Skip to content

Conversation

@Akczht
Copy link

@Akczht Akczht commented Dec 21, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

ffmpeg: make X11 dependencies Linux-only

libx11 and libxcb are only required for X11 functionality, which is
Linux-specific. macOS builds do not use X11, so move these dependencies
under on_linux to avoid unnecessary requirements on macOS.

@Akczht
Copy link
Author

Akczht commented Dec 22, 2025

@botantony, sorry for pinging you but I don't know how to proceed now, should this commit be merged?

@Akczht
Copy link
Author

Akczht commented Dec 22, 2025

the two check failed because they were stuck for a very long time, c=and then they got cancelled

@botantony botantony added the CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. label Dec 22, 2025
@Akczht
Copy link
Author

Akczht commented Dec 22, 2025

all except 1 check failed, that too because it's time ran out or it got stuck idk how, but last time I can remember it passed but 2 other failed, but this time those two passed and this one got stuck and then got cancelled

@botantony botantony added the long dependent tests Set a long timeout for dependent testing label Dec 22, 2025
@Akczht
Copy link
Author

Akczht commented Dec 22, 2025

all checks seem to have passed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. long dependent tests Set a long timeout for dependent testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants