Skip to content

Conversation

@orien
Copy link
Contributor

@orien orien commented Dec 22, 2025

The language server (LSP) for the Pony programming language.

https://github.com/ponylang/pony-language-server

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?
❯ brew audit --new pony-language-server
pony-language-server
  * GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
Error: 1 problem in 1 formula detected.

Given there are formulae for ponyc and corral, I propose we add the LSP for the Pony language (https://github.com/ponylang), even though the GitHub repository is 'not notable enough'.

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 22, 2025
@chenrui333 chenrui333 added notability Project is not notable enough for inclusion CI-skip-new-formulae Pass --skip-new to brew test-bot. labels Dec 22, 2025
@chenrui333
Copy link
Member

skip-new-formula as it seems a good companion tool for ponylang.

@chenrui333 chenrui333 marked this pull request as draft December 22, 2025 03:21
@orien orien force-pushed the pony-language-server branch from 252c6a3 to fdfc77a Compare December 22, 2025 03:29
@orien orien marked this pull request as ready for review December 22, 2025 03:34
Comment on lines 18 to 19
assert_path_exists bin/"pony-lsp"
assert_predicate bin/"pony-lsp", :executable?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these checks are not useful

Suggested change
assert_path_exists bin/"pony-lsp"
assert_predicate bin/"pony-lsp", :executable?

Comment on lines 23 to 29
pony_source_code = <<~PONY
actor Main
new create(env: Env) =>
env.out.print("Hello, world")
PONY

Open3.popen3(bin/"pony-lsp") do |stdin, stdout|
stdin.write "Content-Length: #{pony_source_code.size}\r\n\r\n#{pony_source_code}"
assert_match(/^Content-Length: \d+/i, stdout.readline)
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting some json-rpc interactions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 12c3ef0.

@orien orien force-pushed the pony-language-server branch from fdfc77a to 8525af4 Compare December 22, 2025 14:27
@orien orien force-pushed the pony-language-server branch from 8525af4 to 12c3ef0 Compare December 22, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-new-formulae Pass --skip-new to brew test-bot. new formula PR adds a new formula to Homebrew/homebrew-core notability Project is not notable enough for inclusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants