use lazy state initialization to avoid eager deref calculation #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcnaughton
approved these changes
Feb 18, 2021
Contributor
gmcnaughton
left a comment
gmcnaughton
left a comment
There was a problem hiding this comment.
Thanks for the speedup! 🐎
| enforceDispatcher(dispatcher); | ||
|
|
||
| const [dependencyValue, setDependencyValue] = useState({ | ||
| const [dependencyValue, setDependencyValue] = useState(() => ({ |
Contributor
There was a problem hiding this comment.
This is 💯 !
The only other tweak we could consider is literally moving the const newValue = { dependency: ... } up above here, then reusing newValue both as the initial state and where it is already used. That has the added benefit of skipping an extra eval of the deref in the opposite case (where we are initializing state for the first time)
gmcnaughton
added a commit
to gmcnaughton/general-store
that referenced
this pull request
Feb 19, 2021
See HubSpot#95 Avoids duplicate deref calculations in `useStoreDependency`. Only calculate once; use this result to initialize state (if necessary) and as the next state. When the value changes, two deref calculations will still run: 1. the initial render/hook call 2. the re-render/hook call triggered by setting the new value in state
4 tasks
gmcnaughton
added a commit
to gmcnaughton/general-store
that referenced
this pull request
Mar 15, 2021
See HubSpot#95 Avoids duplicate deref calculations in `useStoreDependency`. Only calculate once; use this result to initialize state (if necessary) and as the next state. When the value changes, two deref calculations will still run: 1. the initial render/hook call 2. the re-render/hook call triggered by setting the new value in state
aem
pushed a commit
that referenced
this pull request
Mar 15, 2021
See #95 Avoids duplicate deref calculations in `useStoreDependency`. Only calculate once; use this result to initialize state (if necessary) and as the next state. When the value changes, two deref calculations will still run: 1. the initial render/hook call 2. the re-render/hook call triggered by setting the new value in state Co-authored-by: Gordon McNaughton <gmcnaughton@hubspot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h/t @gmcnaughton for pointing out that we can optimize this hook with a lazy state init to avoid double-calculating the deref on every render, which can be meaningful for expensive derefs
TODOs
src/GeneralStore.jspackage.jsonCHANGELOG.mdis up to date