Audio zones transform fix and new shapes #1208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirox
reviewed
Jun 28, 2022
takahirox
reviewed
Jun 28, 2022
takahirox
left a comment
takahirox
left a comment
There was a problem hiding this comment.
Honestly, I'm not familiar with Spoke, Andio Zone, or Audio debugger implementation at all. So added a comment for Math so far.
keianhzo
force-pushed
the
audio-zones-sphere
branch
from
1dda0b2 to
867254b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support the a new Sphere shape and fixes issues with the Audio Zones AABB transform visuals.
Fixes Hubs-Foundation/hubs#4806
Fixes Hubs-Foundation/hubs#4996
Related Hubs-Foundation/hubs#5045
Related Hubs-Foundation/hubs-blender-exporter#65