[algorithm] Fix problem with gap in coupling points when puncturing tissue with high stiffness #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n instead of tipToLastCP
…s smaller than the edge length
th-skam
added
pr: status to review
epernod
approved these changes
Sep 14, 2025
epernod
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is described in issue #80 along with a video.
The solution is to change the proximity detection and coupling point addition algorithm. Instead of relying on the tip to detect tetrahedral proximities, the modified algorithm starts from the last coupling point added and traverses the needle edge segments until it reaches the tip while adding evenly spaced coupling points along the way. This avoids creating a gap after puncturing the surface.
25-09-04-PunctureFix.mp4
Fix #80