Skip to content

Remove lower casing of fields in audit details maps #7300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 2 commits into from
Dec 31, 2025
Merged

Remove lower casing of fields in audit details maps #7300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c8d1e9
Remove lower casing of fields in audit details maps
labkey-susanh Dec 31, 2025
cb480d1
Change expected casing
labkey-susanh Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions api/src/org/labkey/api/audit/AuditHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ static Pair<Map<String, Object>, Map<String, Object>> getOldAndNewRecordForMerge
nameFromAlias = encodedInputColumn;
}
}
else
nameFromAlias = lcName;

boolean isExtraAuditField = extraFieldsToInclude != null && extraFieldsToInclude.contains(nameFromAlias);
if (!excludedFromDetailDiff.contains(nameFromAlias) && (row.containsKey(nameFromAlias) || isExpInput))
Expand Down
2 changes: 1 addition & 1 deletion experiment/src/org/labkey/experiment/api/ExpDataClassDataTestCase.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,7 +1257,7 @@ public void testUpdateAuditForLongField() throws Exception
List<AuditTypeEvent> events = AuditLogService.get().getAuditEvents(c, user, "QueryUpdateAuditEvent", filter, new Sort("-RowId"));
assertEquals("Number of audit events not as expected", 2, events.size()); // should have one for insert and one for update
String oldRecordMap = ((DetailedAuditTypeEvent) events.get(0)).getOldRecordMap();
assertTrue("Old record map (" + oldRecordMap + ") does not contain expected field", oldRecordMap.contains(encodeURIComponent(fieldName.toLowerCase()) + "=Initial"));
assertTrue("Old record map (" + oldRecordMap + ") does not contain expected field", oldRecordMap.contains(encodeURIComponent(fieldName) + "=Initial"));
}
}
%>