Skip to content

Conversation

@c-randall
Copy link
Collaborator

Description

This PR adds an hppc module with a function to extract impedance. There is also now an example hppc_discharge dataset, and a zero_below function to help zero out currents below a threshold. However, pytest tests for this new hppc module still need to be completed.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that improves speed/readability/etc.)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ nox -s linter [-- format]
  • Code is free of misspellings: $ nox -s codespell [-- write]
  • All tests pass: $ nox -s tests
  • Badges are updated: $ nox -s badges

Further checks:

  • The documentation builds: $ nox -s docs.
  • Code is commented, particularly in hard-to-understand areas.
  • Tests are added that prove fix is effective or that feature works.

@c-randall c-randall marked this pull request as ready for review November 25, 2025 23:10
@c-randall c-randall merged commit 0e34a57 into main Nov 25, 2025
10 checks passed
@c-randall c-randall deleted the feature/hppc branch November 25, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants