openrc-user: use /bin/sh if user's login shell is not in /etc/shells #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-R-K
suggested changes
Nov 9, 2025
| return true; | ||
|
|
||
| while (xgetline(&line, &size, fp) != -1) { | ||
| if (strcmp(line, shell) == 0) { |
Contributor
There was a problem hiding this comment.
Maybe skip lines starting with #? My /etc/shells has a comment as it's first line.
Member
Author
There was a problem hiding this comment.
they wouldn't match anyway (pw_shell is an absolute path afaik), but sure, simple enough
navi-desu
force-pushed
the
openrc-user-shell
branch
from
2d79be5 to
a6f4751
Compare
navi-desu
force-pushed
the
openrc-user-shell
branch
from
a6f4751 to
b0a858f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #940