openrc-run: posix_spawn-ify plus style adjustments #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navi-desu
force-pushed
the
posix_spawn
branch
from
319dc08 to
eea42f5
Compare
makes the code simpler, since we don't have to care about signals and forking directly, and faster.
odd line breaks were annoying me a lot
navi-desu
force-pushed
the
posix_spawn
branch
from
eea42f5 to
a1d2330
Compare
N-R-K
reviewed
Nov 13, 2025
Comment on lines
+330
to
+331
| posix_spawnattr_init(&chldmask); | ||
| posix_spawnattr_setsigmask(&chldmask, &full); |
Member
Author
There was a problem hiding this comment.
thinking about it, those i want to move to openrc-run itself tbh, better unconditionally unmasking signals where needed, than relying on the caller except in some places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.