[circle-resizer] Add Shape parser

[mbencer]

This commit adds the shapes representation and capabilities to parse string inputs into Shapes objects.

ONE-DCO-1.0-Signed-off-by: Mateusz Bencer m.bencer@partner.samsung.com

Issue: #14791
Draft: #14727

[jinevening]

LGTM

[mbencer]

LGTM

Thank you very much but please give me a moment (before merging) to add doc+unit tests to Shape class ;-)

[jinevening]

Ah, sorry for the impatience. Please let me know when you're ready.

[mbencer]

Ah, sorry for the impatience. Please let me know when you're ready.

@jinevening I believe that's the implementation is ready now ;-)

[jinevening]

LGTM

[seanshpark]

sorry but too huge to review

[jinevening]

@seanshpark I understand. This PR got bigger as @mbencer and I discuss how to handle scalar type. Can we merge as-is with 1 approval or do you want to review splitted PRs?

[seanshpark]

Can we merge as-is with 1 approval or do you want to review splitted PRs?

With the discussion issue, my questions wasn't resolved and still I am not clear with this module's direction or usage scenario with onecc and TICO, but the PR was posted and landed.
Please go as you wish as I understand you've described usage case with TICO.

[mbencer]

@seanshpark

sorry but too huge to review

there is a pretty convenient way now to split the PR into Shape part and parser part. I can prepare such a version

With the discussion issue, my questions wasn't resolved and still I am not clear with this module's direction or usage scenario with onecc and TICO, but the PR was posted and landed.
Please go as you wish as I understand you've described usage case with TICO.

I've collected all(I hope) requests/questions around resizer in #14791 (comment). In particular I agree to stop the idea of a separate python package for resizer. Integration with onecc ecosystem is shown in the draft.
The usage in the test pipeline in TICO I've tried to show in this draft.
Please let me known if you have other questions/requests ;-)

[jinevening]

@seanshpark I landed the entrypoint PR because I thought you agreed to develop circle-resizer as a command line tool (based on the reaction to my comment :) ). There was some remaining discussion on python packaging, but AFAIK that issue is independent with development of circle-resizer.

If you disagree to develop circle-resizer even as a command line tool, please let me know. Then we may need to talk about how to support multiple shapes for generative models.

[mbencer]

sorry but too huge to review

@seanshpark @jinevening Please review a smaller piece of this PR - adding Shape representation at first. After #15165 merge I'll synchronize this PR.

[seanshpark]

I landed the entrypoint PR because I thought you agreed to develop ...

It is OK as you supported this tool.

If you disagree to develop circle-resizer even as a command line tool, please let me know.

not disagree but as I wrote, still uncertain things exist to me.
that includes how current UI and new TICO relations would be, and this tool.
personally I think this tool can be usefull but implementing shape changes for the Ops in luci can require lots of work, and I'm not certain that change would be better in luci or TICO itself.

[jinevening]

From our offline talk,

1. We agree the needs for circle-resizer's functionality, i.e., changing circle's shape.

2. We need more dicussion on how it will be integrated with onecc or python interfacce.

3. I'll review circle-resizer, and @seanshpark will be added as a reviewer when necessary.

I've already reviewed this PR, so #15165 seems unnecessary.