[infra] Discard output from the cd command when followed by pwd #16244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanshpark
reviewed
Oct 27, 2025
seanshpark
reviewed
Oct 27, 2025
seanshpark
reviewed
Oct 27, 2025
seanshpark
reviewed
Oct 27, 2025
seanshpark
reviewed
Oct 27, 2025
seanshpark
reviewed
Oct 27, 2025
seanshpark
reviewed
Oct 27, 2025
seanshpark
reviewed
Oct 27, 2025
seanshpark
reviewed
Oct 27, 2025
This commits fixes the issue when `cd` is followed by the `pwd` in a bash one-liner which should get the directory in which the executed script is located. The problem with such approach is that the `cd` command can print the destination directory in case when one has the CDPATH environmental variable set. From the `man bash`: > cd [-L|...] [dir] > Change the current directory to dir. [...] If a non-empty directory > name from CDPATH is used the absolute pathname of the new working > directory is written to the standard output. ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy <a.bokowy@samsung.com>
arkq
force-pushed
the
bash-cd-fix-infra
branch
from
e739421 to
e0235c0
Compare
Contributor
Author
|
@seanshpark all comments have been addressed, please re-review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits fixes the issue when
cdis followed by thepwdin a bash one-liner which should get the directory in which the executed script is located. The problem with such approach is that thecdcommand can print the destination directory in case when one has the CDPATH environmental variable set.From the
man bash:This PR is part of draft #16238
Testing
Verified locally that now, on the host with
CDPATHset, it is possible to list and run commands when outside repo dir:ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy a.bokowy@samsung.com