Unblock Partners API #6708
Merged
Unblock Partners API #6708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/constants.d.ts@@ -29,7 +29,6 @@ export declare const environmentVariables: {
themeKitAccessDomain: string;
json: string;
neverUsePartnersApi: string;
- usePartnersApi: string;
skipNetworkLevelRetry: string;
maxRequestTimeForNetworkCalls: string;
};
|
2 tasks
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3487 tests passing in 1406 suites. Report generated by 🧪jest coverage report action from 3495253 |
amcaplan
approved these changes
Dec 11, 2025
Contributor
Author
Merge activity
|
This was referenced Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/shopify-dev/issues/65805
Related to https://community.shopify.dev/t/unable-to-migrate-extensions-and-deploy/26901
In #6645 we blocked Partners API by default, but it's still needed to import extensions.
Discussion about the approach: https://shopify.slack.com/archives/C07UJ7UNMTK/p1765301233241769
WHAT is this pull request doing?
Basically reverts:
How to test your changes?
p shopify app info --reset --verbose: uses both APIsSHOPIFY_CLI_NEVER_USE_PARTNERS_API=1 p shopify app info --reset --verbose: does not use Partners APIMeasuring impact
How do we know this change was effective? Please choose one:
Checklist