check test helper shouldn't silently swallow errors
#785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Another small one from me. Currently the
check()test helper (which wraps the maincheck()export) will happily run a broken rule and report no issues. That is, given a check like this:a test like this will be green:
This PR overrides the default no-op
onErrorso that we properly rethrow errors when running tests, rather than silently squelching all error output. Fortunately, this doesn't seem to unmask any broken test cases. I can't really think of any reason this shouldn't be the default — callers of thecheck()test helper can wrap it intry...catchif they genuinely have some reason to expect a check to throw, though my intuition is that checks should never be doing that on purpose.