Accommodate Faraday gem deprecation for Faraday::Error::ClientError
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorint
force-pushed
the
accommodate-faraday-gem-deprecation-for-client_error
branch
from
a314cd5 to
99d40cf
Compare
lorint
force-pushed
the
accommodate-faraday-gem-deprecation-for-client_error
branch
2 times, most recently
from
ff7f867 to
8823d7e
Compare
lorint
force-pushed
the
accommodate-faraday-gem-deprecation-for-client_error
branch
from
8823d7e to
223f2e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Faraday gem (intrinsic to the restforce gem which we use in active_force) now uses
Faraday::ClientErrorin place ofFaraday::Error::ClientError.This also moves active_attr and restforce up to the most recent, allowing for us to use Ruby 2.7+. This brings security benefits and also exposes us to potential unexpected incompatibilities. When implementing this change, it will be critical for us to perform exhaustive QA to confirm that there are no new issues which might surface by introducing this updated code base.
(Likely evident, but good to note that this causes us to further diverge from the original code base owned by Ionia corp. They had archived this gem three years ago.)