feat!: change {{else}} to {{#else}} for syntax consistency #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The else marker syntax has changed from {{else}} to {{#else}}
to be consistent with other control flow markers ({{#if}}, {{#elseif}}, {{#foreach}}).
Existing templates using {{else}} must be updated to {{#else}}.
- Fix 2 nested {{else}} in Demo/Program.cs
- Update documentation in REFACTORING.md and TODO.md
- Regenerate conditionals-template.docx with new syntax
- Update screenshots to reflect {{#else}} syntax
There was a problem hiding this comment.
Pull request overview
This pull request introduces a breaking change to improve syntax consistency across all control flow markers in the templating engine. The change modifies the else marker from {{else}} to {{#else}}, making all control flow markers follow the same pattern with a # prefix: {{#if}}, {{#elseif}}, {{#else}}, {{#foreach}}.
Key Changes:
- Updated the core regex pattern in ConditionalPatterns.cs to recognize
{{#else}}instead of{{else}} - Modified 8 source files to handle the new syntax
- Updated 10+ documentation files with the new syntax examples
- Regenerated template and output files to reflect the changes
Reviewed changes
Copilot reviewed 37 out of 41 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/index.md | Updated main documentation to show {{#else}} in conditional examples |
| docs/for-template-authors/template-syntax.md | Updated all conditional syntax examples and references throughout the template syntax guide |
| docs/for-template-authors/loops.md | Updated conditional examples within loop contexts |
| docs/for-template-authors/getting-started.md | Updated getting started examples to use new syntax |
| docs/for-template-authors/conditionals.md | Comprehensive updates to all conditional documentation and examples |
| docs/for-developers/text-templates.md | Updated text template examples for developers |
| docs/FAQ.md | Updated FAQ examples to reflect new syntax |
| TriasDev.Templify/Visitors/TemplateElement.cs | Updated XML documentation comments |
| TriasDev.Templify/Visitors/ITemplateElementVisitor.cs | Updated interface documentation |
| TriasDev.Templify/Visitors/DocumentWalker.cs | Updated marker detection logic and comments |
| TriasDev.Templify/Visitors/ConditionalVisitor.cs | Updated error messages and marker detection code |
| TriasDev.Templify/TODO.md | Updated implementation notes |
| TriasDev.Templify/REFACTORING.md | Updated refactoring documentation |
| TriasDev.Templify/README.md | Updated feature descriptions and examples |
| TriasDev.Templify/PERFORMANCE.md | Updated performance documentation |
| TriasDev.Templify/Core/TextTemplateProcessor.cs | Updated text template processing logic |
| examples/templates/conditionals-template.docx | Regenerated template file (binary) |
| examples/outputs/conditionals-output.docx | Regenerated output file (binary) |
| docs/images/examples/outputs/conditionals-output.png | Regenerated screenshot (binary) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
{{else}}to{{#else}}for consistency with other control flow markers{{#if}},{{#elseif}},{{#else}},{{#foreach}}BREAKING CHANGE
Existing templates using
{{else}}must be updated to{{#else}}.Changes
ConditionalPatterns.csTest plan