Skip to content

Conversation

@tom-ridsdale
Copy link
Contributor

@tom-ridsdale tom-ridsdale commented Dec 11, 2025

Problem

  • release workflow failing with npm error LRU is not a constructor.

Investigation

  • Reproduced locally by running the failing npm version command. Found that yarn 1.18.0's hoisting caused semver@7.5.2 to resolve lru-cache@11.x instead of ^6.0.0. The API changed between versions (new LRU() → new LRUCache()), causing the crash (couldn't find its own lru-cache@6 in its nested node_modules, so Node's resolution walked up and found the root lru-cache@11 instead).
  • js-api-client works because it uses system yarn 1.22.x with correct hoisting.

Fix

  • Removed pinned yarn 1.18.0 (.yarnrc, .yarn/releases/)
  • Regenerated yarn.lock
  • Pinned @typeform/eslint-config@6.0.3 and @visual-regression-tracker/agent-cypress@5.6.0 to prevent breaking upgrades
  • Added resolution for @types/minimatch@5.1.2
  • Removed stale packages/demo-nextjs/yarn.lock

@tom-ridsdale
Copy link
Contributor Author

yarn build & yarn test running successfully locally

@tom-ridsdale tom-ridsdale marked this pull request as ready for review December 11, 2025 15:53
@tom-ridsdale tom-ridsdale requested a review from a team as a code owner December 11, 2025 15:53
@gitstream-cm
Copy link

gitstream-cm bot commented Dec 11, 2025

🥷 Code experts: tf-security

tf-security has most 👩‍💻 activity in the files.
tf-security has most 🧠 knowledge in the files.

See details

package.json

Activity based on git-commit:

tf-security
DEC 1 additions & 1 deletions
NOV
OCT
SEP
AUG
JUL 82 additions & 0 deletions

Knowledge based on git-blame:
tf-security: 94%

yarn.lock

Activity based on git-commit:

tf-security
DEC 57 additions & 57 deletions
NOV
OCT
SEP
AUG
JUL 18497 additions & 0 deletions

Knowledge based on git-blame:
tf-security: 89%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

@typeform-ops-gha
Copy link

[BOT] Preview available with hash 1d0107618edc1a325100792eb5b74d2a7b4a70e2 here.

@sonarqubecloud
Copy link

@tom-ridsdale tom-ridsdale merged commit fc14b54 into main Dec 11, 2025
18 checks passed
@tom-ridsdale tom-ridsdale deleted the feat/TU-33149 branch December 11, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants