Skip to content

Conversation

@tom-ridsdale
Copy link
Contributor

@tom-ridsdale tom-ridsdale commented Dec 12, 2025

Fixes the release script failures caused by yarn upgrade incompatibility with yarn 1.22.x in workspaces.

Changes:

  • Replace yarn upgrade commands with npm view + sed to update version strings in package.json
  • Remove references to deleted demo-react and demo-webpack packages
  • Target demo-nextjs explicitly instead of packages/demo-* wildcard

Problems fixed:

  1. yarn upgrade was failing with "expected workspace package to exist for webpack" - a known yarn 1.22.x bug with workspaces
  2. Script was trying to cd into non-existent demo-react and demo-webpack directories

Testing:

  • Verified sed commands work locally, manually replicated the flow as best I can locally.

@tom-ridsdale tom-ridsdale marked this pull request as ready for review December 12, 2025 16:16
@tom-ridsdale tom-ridsdale requested a review from a team as a code owner December 12, 2025 16:16
@gitstream-cm
Copy link

gitstream-cm bot commented Dec 12, 2025

🥷 Code experts: tf-security

tf-security has most 👩‍💻 activity in the files.
tf-security has most 🧠 knowledge in the files.

See details

scripts/release.sh

Activity based on git-commit:

tf-security
DEC
NOV
OCT
SEP
AUG
JUL 52 additions & 0 deletions

Knowledge based on git-blame:
tf-security: 100%

yarn.lock

Activity based on git-commit:

tf-security
DEC 57 additions & 57 deletions
NOV
OCT
SEP
AUG
JUL 18497 additions & 0 deletions

Knowledge based on git-blame:
tf-security: 58%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

@typeform-ops-gha
Copy link

[BOT] Preview available with hash 0d6514712d7aeee1cf48fdf9cac509d90c9d540f here.

@sonarqubecloud
Copy link

@tom-ridsdale tom-ridsdale merged commit d25904a into main Dec 12, 2025
16 checks passed
@tom-ridsdale tom-ridsdale deleted the feat/TU-34342 branch December 12, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants