Determinization/inclusion using the boost library. #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… boost, use USE_BOOST=1 (or 0 if not, though that is the default behaviour anyway). Wrapped all code that is dependent on boost (so boost-vector.hh, some algorithms, debug functions, test cases in unit tests and perftests in tests-integration/) into a #ifdef USE_BOOST....#endif block for this to function correctly.
…ning the final states straight away and also passing a size parameter to unify_targets_boost (both cases would probably be resized just once anyway, but in the case of unify_targets_boost which is called a lot of timesit could be a lag on the overall performance)
…ed into a unordered map which will avoid repetead computation of these values
Collaborator
|
Hmm, it is a shame so much of the Boost library is needed. This basically means the integration of a subset of the Boost library to Mata is useless, and we can just add Boost as a simple optional dependency, without which certain files using the Boost library will not be compiled. The problem is that then one kind of cannot use the Boost library anywhere in the project reasonably. Boost would need to be a required dependency in order to allow for using the library wherever it might be beneficial... |
Collaborator
|
@kilohsakul Have a look at how much of a Boost is needed here. Including this into Mata would enlarge the project thousandfold. Any opinions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains versions of the determinize/is_included() algorhiotms using the boost library's bit vectors as opposed to OrdVectors.