[WIP] Select reduction algorithm in noodlifications #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adda0
reviewed
Apr 15, 2025
| product_pres_eps_trans = reduce(product_pres_eps_trans, nullptr, red_alg); | ||
| } | ||
| return noodlify_mult_eps(product_pres_eps_trans, { EPSILON, EPSILON-1 }, include_empty); | ||
| return noodlify_mult_eps(product_pres_eps_trans, { EPSILON, EPSILON-1 }, red_alg); |
Collaborator
There was a problem hiding this comment.
It took me a few seconds to decipher red_alg. Could we just use the full name?
Member
Author
There was a problem hiding this comment.
This PR is right now for experimental purposes, so this is very low effort thing.
Collaborator
There was a problem hiding this comment.
Sure, I was just quickly scrolling through.
jurajsic
force-pushed
the
change_reduce_in_strings
branch
from
277599a to
aa23aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #519