Skip to content

fix(RAC): use ICB size as the fallback value for visual viewport #9384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lixiaoyan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(RAC): use ICB size as the fallback value for visual viewport #9384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/@react-aria/utils/src/useViewportSize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export function useViewportSize(): ViewportSize {
frame = requestAnimationFrame(() => {
if (!document.activeElement || !willOpenKeyboard(document.activeElement)) {
setSize(size => {
let newSize = {width: window.innerWidth, height: window.innerHeight};
let newSize = {width: document.documentElement.clientWidth, height: document.documentElement.clientHeight};
if (newSize.width === size.width && newSize.height === size.height) {
return size;
}
Expand Down Expand Up @@ -91,7 +91,7 @@ export function useViewportSize(): ViewportSize {
function getViewportSize(): ViewportSize {
return {
// Multiply by the visualViewport scale to get the "natural" size, unaffected by pinch zooming.
width: visualViewport ? visualViewport.width * visualViewport.scale : window.innerWidth,
height: visualViewport ? visualViewport.height * visualViewport.scale : window.innerHeight
width: visualViewport ? visualViewport.width * visualViewport.scale : document.documentElement.clientWidth,
height: visualViewport ? visualViewport.height * visualViewport.scale : document.documentElement.clientHeight
};
}