Skip to content

Conversation

@yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Dec 23, 2025

an attempt to fix some of the issues here: https://www.chromatic.com/test?appId=651b502f6b74abaae4ee734c&id=693a03813f3423341ad07199

didn't have any great ideas of how to fix the layering issue in HCM caused by selectionSpanStyles. instead, i just removed Highlight from backgroundColor and made the border transparent

on main:
Screenshot 2025-12-22 at 5 20 14 PM

in pr:
Screenshot 2025-12-22 at 5 21 47 PM

not sure if we're okay with the white background for the selected range...

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Dec 23, 2025

@rspbot
Copy link

rspbot commented Dec 23, 2025

## API Changes

react-aria-components

/react-aria-components:ColorFieldRenderProps

 ColorFieldRenderProps {
   channel: ColorChannel | 'hex'
   isDisabled: boolean
   isInvalid: boolean
-  isReadOnly: boolean
-  isRequired: boolean
   state: ColorFieldState
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants