fix(kotlin-ls): improve root detection for Gradle multi-project builds #6717
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the Kotlin language server is started at the correct Gradle root for multi-project and composite builds. The root resolution now prioritizes settings.gradle(.kts), followed by the Gradle wrapper, before falling back to module-level build files or Maven projects. This prevents submodules from being incorrectly detected as the workspace root.
tjg184
reviewed
Jan 3, 2026
Root detection now correctly handles async NearestRoot resolution. The previous implementation relied on nullish coalescing, which does not work with async functions and could incorrectly detect a subproject as the root. This change resolves roots sequentially using await and early returns. Priority order: 1. settings.gradle(.kts) for multi-project and included builds 2. Gradle wrapper as a strong root signal 3. build.gradle(.kts) for single-project or module builds 4. pom.xml as a Maven fallback Also renames `start` to `file` for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the Kotlin language server is started at the correct Gradle root for multi-project and composite builds.
The root resolution now prioritizes settings.gradle(.kts), followed by the Gradle wrapper, before falling back to module-level build files or Maven projects. This prevents submodules from being incorrectly detected as the workspace root.
Follow up for #6601