Fix AWS StaticSite file upload order
#6289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2025
| oldFile.ContentType == file.ContentType { | ||
| continue | ||
| } | ||
| if strings.HasSuffix(file.Key, ".html") { |
Collaborator
There was a problem hiding this comment.
Would it be better just to break the files into these 2 groups instead of html and nonHtml:
- updatedFiles: Files that have an existing key and have a different hash <--- upload these last
- createdFiles: Files that do not have an existing key <---- upload these first
This should still solve the race issue, and avoids having to bring in and handle specific file extension logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when checking what files to upload for static sites we do it in the appropriate order (html then the rest) to avoid deploying a new html that references a not-yet-uploaded file
however, there's still a problem because all the files are uploaded in parallel, so it might still happen that the html file is uploaded before the rest
this pr implements a fix to ensure that the non-html files are always uploaded first
i've tested against some of the AWS `StaticSite` examples and it worked flawlessly