Skip to content

Conversation

@HyukjinKwon
Copy link
Member

Rationale for this change

63b8b7e: ARROW-13800 Added the TODOs
2468992: ARROW-14297 Added the tests but forgot to remove TODOs.

int_div_zero_int = integers %/% 0L,
int_div_zero_dbl = integers %/% 0,

dbl_div_zero_int = doubles %/% 0L,
dbl_div_zero_dbl = doubles %/% 0

What changes are included in this PR?

This PR proposes to remove the obsolete todo about integer division by zero tests.

Are these changes tested?

No, I did not test this.

Are there any user-facing changes?

No, dev-only.

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! One small comment, I don't mind duplicating the test behavior in the place where the todo was so that we have all the arithmetic tests in one place (even though they are also tested in the dplyr tests too, we already have a bunch of overlap there too)

Comment on lines -74 to -75
# TODO add tests for integer division %/% by 0
# see https://issues.apache.org/jira/browse/ARROW-14297
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mind also having a test here as well as the dplyr tests. Or alternatively: maybe we mention that the %/% tests are in the dplyr math file?

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants