Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

Conversation

@ravening
Copy link
Member

@ravening ravening commented Nov 6, 2020

Provide a cleanup flag so that the project will
be deleted only when there are no resources left
in the project. If users click on delete project
by mistake then everything is deleted.

NOTE: Backend change is in apache/cloudstack#4453

Screenshot 2020-11-06 at 14 28 35

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@davidjumani
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@rohityadavcloud rohityadavcloud added this to the 1.1 milestone Nov 11, 2020
@davidjumani
Copy link
Contributor

davidjumani commented Nov 11, 2020

@ravening Could you add a check whether the parameter exists for the API, similar to https://github.com/apache/cloudstack-primate/blob/master/src/config/section/compute.js#L112
It breaks on versions without the cleanup parameter

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/848 (JID-3660)

@ravening
Copy link
Member Author

@ravening Could you add a check whether the parameter exists for the API, similar to https://github.com/apache/cloudstack-primate/blob/master/src/config/section/compute.js#L112
It breaks on versions without the cleanup parameter

@davidjumani I can add that but this feature is supported 4.15 onwards only. I dont think there will be other version where this is supported

Provide a cleanup flag so that the project will
be deleted only when there are no resources left
in the project. If users click on delete project
by mistake then everything is deleted.
@ravening
Copy link
Member Author

@ravening Could you add a check whether the parameter exists for the API, similar to https://github.com/apache/cloudstack-primate/blob/master/src/config/section/compute.js#L112
It breaks on versions without the cleanup parameter

@davidjumani I can add that but this feature is supported 4.15 onwards only. I dont think there will be other version where this is supported

@davidjumani made changes

@davidjumani
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/848 (JID-3681)

Copy link
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants