-
Notifications
You must be signed in to change notification settings - Fork 36
Provide option to force delete the project #848
base: master
Are you sure you want to change the base?
Conversation
GabrielBrascher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
@ravening Could you add a check whether the parameter exists for the API, similar to https://github.com/apache/cloudstack-primate/blob/master/src/config/section/compute.js#L112 |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
@davidjumani I can add that but this feature is supported 4.15 onwards only. I dont think there will be other version where this is supported |
Provide a cleanup flag so that the project will be deleted only when there are no resources left in the project. If users click on delete project by mistake then everything is deleted.
563fd2c to
16b36ad
Compare
@davidjumani made changes |
16b36ad to
ad4c25a
Compare
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
davidjumani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Provide a cleanup flag so that the project will
be deleted only when there are no resources left
in the project. If users click on delete project
by mistake then everything is deleted.
NOTE: Backend change is in apache/cloudstack#4453